Normalize missing FIT lap bounds and grade-adjusted speed units - #49
Merged
tabishm52 merged 2 commits intoOct 3, 2026
Merged
Conversation
test_table_covers_installed_profile already pins these entries against the installed profile, and existing tests cover the lap and raw conversion paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for the fix! I pushed a small follow-up: sorted the new entries into the existing table order, bumped the SDK version in the module docstring, and dropped the new tests and README note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The unbounded
garmin-fit-sdkdependency currently resolves to 21.217.0. Its profile exposes five lap fields and one session field that are missing from the unit-conversion tables:nec_lat,nec_long,swc_lat,swc_longstay in semicircles rather than degrees.avg_grade_adjusted_speedstays in m/s rather than km/h.This also causes the existing
test_table_covers_installed_profiletests for lap and session to fail. For example, a synthetic lap parsed withinclude_all_columns=Truereturnsnec_lat=536870912instead of45.0, andavg_grade_adjusted_speed=10.0instead of36.0.Fix
Add the missing entries to the existing tables. No new dependencies, default output columns or public APIs; existing vertical-rate exceptions and raw FIT-native parsing remain unchanged.
Tests
Prepared with AI assistance; all stated tests were actually run using synthetic FIT data. Tests on this Windows machine used Python UTF-8 mode because existing README tests read UTF-8 text with the platform-default encoding.