Internal cleanups: stale docstring, index_by_time mutation, infer_extension message - #47
Merged
Merged
Conversation
output.py was removed in PR #40; the columns it checks now live in parser.py. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The empty-and-column-absent branch wrote NaT into the input in place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
infer_extension silently returned "" instead of reusing normalize_extension's guard. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output.pyreference intest_readme.py's docstring; now saysparser.py.index_by_timeno longer mutates the caller's DataFrame.infer_extensionraisesAmbiguous extensionfor barefile.gz, matchingnormalize_extension.No behavior change on any currently-tested path.
Test plan
🤖 Generated with Claude Code