Skip to content

Raise FitError for an empty FIT file #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tabishm52 merged 1 commit into from
Sep 6, 2026
Merged

Raise FitError for an empty FIT file #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/activity_parser/parse_fit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ def decode_fit(
except (gzip.BadGzipFile, zlib.error, EOFError) as e:
raise FitError(str(e)) from e

if not data:
raise FitError("Empty FIT file")

messages, errors = Decoder(Stream.from_byte_array(data)).read(
enable_crc_check=check_crc, merge_heart_rates=merge_heart_rates
)
Expand Down
12 changes: 12 additions & 0 deletions tests/test_parse_fit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,18 @@ def test_non_fit_bytes_raise():
parse_fit(io.BytesIO(b"this is not a FIT file"))


@pytest.mark.parametrize("parser", [parse_fit, parse_fit_raw])
def test_zero_byte_file_raises(parser):
with pytest.raises(FitError, match="[Ee]mpty"):
parser(io.BytesIO(b""))


@pytest.mark.parametrize("parser", [parse_fit, parse_fit_raw])
def test_short_garbage_stub_raises(parser):
with pytest.raises(FitError, match="not a fit file"):
parser(io.BytesIO(b"\x00" * 13))


@pytest.mark.parametrize(
"corrupt_bytes",
[
Expand Down