Stop deriving Activity fields for a file holding more than one activity - #41
Merged
Merged
Conversation
Merged records/laps from a chained FIT file, multi-Activity TCX, or multi-track GPX can't be attributed to just the first activity, so those fields are left None instead of a mixed aggregate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill_activitywhen a file has more than one session/Activity/track, since merged records/laps can't be attributed to just the first activitytest_readme.pysection-boundary bug found along the wayTest plan
uv run pytestuv run ruff check/uv run ruff format --checkuv run pyrightuv run pre-commit run --all-files