Reorganize and consolidate source files for clarity - #40
Merged
Merged
Conversation
- Merge output.py and derive.py into activity.py - Rename parse_activity.py to parser.py, moving DEFAULT_RECORD_COLUMNS and DEFAULT_LAP_COLUMNS in alongside it - Rename parse_fit_file.py to parse_fit.py Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tabishm52
added a commit
that referenced
this pull request
Sep 6, 2026
…ension message (#47) * Fix stale output.py reference in test_readme docstring output.py was removed in PR #40; the columns it checks now live in parser.py. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Stop index_by_time mutating the caller's DataFrame The empty-and-column-absent branch wrote NaT into the input in place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Raise Ambiguous extension for a bare file.gz infer_extension silently returned "" instead of reusing normalize_extension's guard. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_LAP_COLUMNS in alongside it
Test plan
uv run pytest(195 passed)uv run ruff check/uv run ruff format --checkuv run pyrightuv run pre-commit run --all-files