Repository navigation
Conversation
Add [tool.pyright] venvPath/venv so pyright resolves imports against the project's .venv, matching the installed dependencies instead of a global environment. Assisted-by: ClaudeCode:claude-opus-4.8
…config chore: point pyright at the project .venv
…ull atlases from filling the RAM
Brainglobe atlas efficient loading + fixed memory leak
fixed paper figure 1 caption
fixed fig1 caption
Add machine-readable citation metadata so GitHub shows a "Cite this repository" button. The preferred citation is the JOSS paper (10.21105/joss.11008); the software entry points to the v1.4.0 JOSS release archived on Zenodo (10.5281/zenodo.22850328), with the concept DOI listed for all versions. Builds on m-beau#45. Assisted-by: ClaudeCode:claude-opus-5-5
…-beau#63 docs: add CITATION.cff referencing the JOSS paper and v1.4.0 release
This was referenced Oct 14, 2026
…chdog Production logs show the single-threaded Bokeh event loop freezing for 20-90 s after nearly every electrode click: the periodic memory log fires late right after each "Selection changed". on_electrode_selection ran a full gc.collect() on every tap, which walks every live object in a multi-GB process. While frozen, healthchecks fail and the proxy drops websockets (the burst of 236 AssertionErrors on PATCH-DOC for an already-destroyed session), and the container eventually dies without a traceback. - Remove the gc.collect() from on_electrode_selection. - Add pixelmap/gui/watchdog.py: a heartbeat on the event loop plus a daemon thread that logs a "[watchdog]" WARNING with the blocked thread's stack when the loop stalls (PIXELMAP_STALL_WARN_S, default 5 s; 0 disables), logs again on recovery, and warns once when RSS crosses PIXELMAP_RSS_WARN_MB (with re-arm hysteresis). It only logs; it never raises into the app or kills it. - Install it once per process from app_util.main(local=False) and set the thresholds in docker-compose.yml. - Regression tests for the per-click gc and for the watchdog. Assisted-by: ClaudeCode:claude-opus-5-5
tabedzki
force-pushed
the
tabedzki/fix/selection-gc-stall
branch
from
October 16, 2026 00:04
4e8cc31 to
7c7898d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Human guided, AI assisted PR (using this skill). AI text below. 🤖
Refs #6
Problem
The production container (
ghcr.io/m-beau/pixelmap) runs for hours and then dies with no traceback. In about 14 h of logs:Memory usagelog fired 20–90 s late 23 times, nearly always right afterSelection changed: [] -> [N]. A late log means the single Bokeh event loop was blocked that long.Failed sending message as connection was closedfollowed by 236AssertionError: assert self._session is not Noneon queuedPATCH-DOCmessages.on_electrode_selectionran a fullgc.collect()on every tap.Changes
gc.collect().pixelmap/gui/watchdog.py, which only logs and never raises or kills anything:[watchdog] event loop blocked for X swith the blocked thread's stack (PIXELMAP_STALL_WARN_S, default 5,0disables). It logs again with the total duration when the loop recovers.PIXELMAP_RSS_WARN_MBand re-arms below 90%, so RSS hovering at the limit doesn't flood Slack.app_util.main(local=False); thresholds set indocker-compose.yml.tests/test_selection_responsiveness.py(no gc on tap, box select or repeated taps; toggle and empty-selection behaviour kept) andtests/test_watchdog.py(threshold edges, report-once-per-stall, recovery and re-arm, stack capture, disabled/0/negative/None configs, idempotent install).Testing
panel serve(very low thresholds): the stall warning with stack, the RSS warning and the recovery line all appear in the server log.Related
maintogether (565 tests pass on the combination).update_electrode_colorsrebuilds every column in Python on each click (a performance follow-up).Supersedes #5, which GitHub closed when its branch was renamed from
t3code/3887861a.Assisted-by: Claude-Code:Opus-5.5