fix(xugu): route type expansion through member metadata - #6281
Merged
Conversation
mapan0424
force-pushed
the
codex/xugu-type-member-expansion-fix
branch
from
August 20, 2026 02:56
d8f4e0a to
50a3923
Compare
mapan0424
marked this pull request as ready for review
August 20, 2026 02:56
t8y2
reviewed
Aug 20, 2026
t8y2
left a comment
Owner
There was a problem hiding this comment.
Maintainer patch applied on reviewed head 50a3923, producing f34cfea.
- Forced tree restoration now reloads expanded Xugu type members instead of entering the user-click toggle/collapse branch.
- Normal click behavior remains unchanged.
- Verified: 2 focused Vitest files passed (59/59), pnpm typecheck passed, and git diff --check passed.
The patch was pushed by fast-forward without rewriting contributor history.
Owner
|
Thanks for the contribution! Merged in 90af026, will be released in the next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Xugu object type expansion when the sidebar restores or loads a tree node through the generic metadata path.
User-visible problem
Expanding a Xugu object type could issue a table-column lookup against the type name and return a vendor error indicating that the table or view did not exist. The type itself was valid; only the metadata route was incorrect.
Root cause
The direct sidebar click path already recognized Xugu object types and loaded their attributes and methods through the scoped completion endpoint. However, the shared
loadTreeNodeChildrenpath used by tree restoration and refresh handled everytypenode with the generic custom-type loader. That path treats the object name as a relation and can eventually request table columns, which is invalid for Xugu object types.Changes
loadXuguTypeMembersfrom the shared tree loader.Compatibility and scope
This is a narrow frontend metadata-routing fix. It changes behavior only when the connection is Xugu and the node is explicitly marked as an expandable object type. Other database types and existing custom-type handling are unchanged.
Validation
git diff --checkpassed.