Repository navigation
setup-project-specs - #23
Merged
Merged
Conversation
Record the product goal, architecture, and the boundaries for the meadow, Life, the Conway explanation, and visitor language.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed the imported spec graph and filled the gaps that were real decisions, not missing files. The legal notice is one footer page, and it is the only exception to the visitor-string dictionary: German on that page is binding, English is a courtesy translation. Shared grid focus stops at the edge, and Life's withered count is last-generation deaths rather than an age stage.
Impressum was not given its own spec. The shell already treats that route as not a module boundary. Shared speed names and cell position were already covered there. Specs stay
draftuntil you review them.Changes
i18nexception. The shell owns why, and does not copy the operator's name or address.Testing
Plan
Fill spec graph gaps
Align the goal with the single legal page
The goal now matches the route: one footer page holds the operator statement and the privacy notice. A second legal module would have contradicted the shell spec.
Verified: not verified
Record the legal page outside the string dictionary
The string invariant now has one named exception: the legal page. German there is binding, English is a courtesy translation, and the operator's details stay on the page rather than being copied into specs.
Hosting and analytics sentences stay the notice's claims. This repo has no analytics client, so that part is marked unconfirmed rather than written as app behavior.
Verified: not verified
Record non-wrapping focus and withered counts
Shared keyboard focus stops at the grid edge, so Life wrap cannot be mistaken for a focus rule. The withered count is last-generation deaths, not another age stage.
No new module specs. Impressum and the shared helpers were already inside the shell boundary.
Verified: spec_validate → valid, no issues
Committed outside the plan
a67438d)Review: 0/1 steps reviewed in ThinkRail.