Conversation
experiments/swebench_lite/run_in_loop.py never created a ConversationLogger, so with log_conversations: true (which the CLI honours) every benchmark trajectory was discarded: after a full evaluation night ~/.godspeed/training did not exist for those runs. The runner now writes <global_dir>/training/<session>.conversation.jsonl, with the terminal session_end record (exit reason and code from EXIT_REASON_TO_CODE), and closes the file on every exit path. Tests: tests/test_run_in_loop_wiring.py gains a test that the log and its session_end record exist when enabled and are absent when disabled; the enabled test fails without this change.
🤖 Godspeed Review
SecurityNo secrets detected in changed files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
experiments/swebench_lite/run_in_loop.pynever created aConversationLogger, solog_conversations: true(which the CLI honours) did nothing for benchmark runs. After a full night of agent-in-loop evaluation (dozens of agent sessions) there was notraining/directory at all. Benchmark runs generate exactly the trajectories any later tuning needs (tool calls, thinking, outcomes, all scored by the official harness), and they were being discarded.Changes
ConversationLoggerwhensettings.log_conversationsis on, passes it toConversation, writes the terminalsession_endrecord (exit reason and code fromEXIT_REASON_TO_CODE, iterations, tool calls, duration, cost) and closes the file on every exit path (normal, timeout, exception).Verification
tests/test_run_in_loop_wiring.pygains two tests: withlog_conversations: trueone<session>.conversation.jsonlexists, starts with the system record and ends with asession_endrecord (exit_reason: stopped,exit_code: 0); with it off no file is written. The enabled-case test fails without this change and passes with it (checked).ruff check ./ruff format --check .clean.Not verified
session_endrecords, so the per-turn records rely on the existingConversationlogging that the CLI path already exercises.