Add ordering-switch completeness guardrail to M1 - #506
Merged
Conversation
The final review round signed off on the plan with one addition: a grep proving no message-reading path still orders by created_at after the position switch. Folded in as a permanent guardrail test with an allowlist of the legitimate cross-thread orderings, rather than a one-time manual check - the bug it guards against is invisible on fresh data (the two orderings coincide until a recovery row lands with a fractional position), so a straggler or a later-added query would pass every demo and misorder exactly the transcripts that needed healing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only amendment from the final review round's sign-off: M1 gains a completeness proof for the created_at-to-position ordering switch - a grep-based permanent guardrail test with an allowlist of the legitimate cross-thread orderings (same pattern as the style/markdownlint guardrail tests), upgraded from the review's one-time manual grep because the bug it guards against is invisible on fresh data (the two orderings coincide until a recovery row lands with a fractional position), so a later-added created_at reader would regress silently without it.
Generated by Claude Code