Fold second review round into the conversation-forking plan - #505
Merged
Conversation
The semantic chunk-search RPC joins threads filtering only by user, and both of its edge-function callers exclude only the current thread - so M3 gains the one-line hidden filter there, plus an explicit M4 handoff note: once forks exist, hidden ancestors' chunks are live prefix content, so the blanket filter must give way to hidden-hit resolution or recall goes blind to every shared prefix. M1 corrections: the position trigger's thread-row lock is new contention, not a ride on a lock writers already hold (edge-side round persistence never touches the thread row; the browser updates it in a separate call), and the two created_at-serving indexes need position companions with the old ones dropped once readers switch. Smaller: the auto-title row now admits a fork of a placeholder-titled parent inherits the placeholder (the poll titles it independently - acceptable); followups get a worker-table row (user-scoped, cross-thread by design); M2 gains an audit for uniform-thread_id assumptions over the resolved message list; the GC cron slot is pinned to :43, the gap in the hourly ladder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only amendment folding the second independent review round into the forking plan: M3 gains the hidden filter on the semantic chunk-search RPC (server-side surface both edge callers rely on) plus an M4 handoff note (once forks exist, hidden ancestors' chunks are live prefix content, so the blanket filter must yield to hidden-hit resolution or recall goes blind to shared prefixes); M1 gains position-index companions for the two created_at-serving indexes and an honest account of the position trigger's new thread-row lock (edge-side inserts never touched the thread row); the worker table admits the auto-title placeholder inheritance case and adds a followups row (user-scoped, cross-thread by design); M2 gains a uniform-thread_id audit over the resolved message list; the GC cron slot is pinned to :43 (:53, as originally suggested in review, is already taken in the hourly ladder).
Generated by Claude Code