Skip to content

fix(tools): cancel rejected image download streams - #993

Open
xiaofeilovecoding wants to merge 1 commit into
synthetic-sciences:mainfrom
xiaofeilovecoding:fix/image-download-error-cleanup
Open

xiaofeilovecoding wants to merge 1 commit into
synthetic-sciences:mainfrom
xiaofeilovecoding:fix/image-download-error-cleanup

Conversation

@xiaofeilovecoding

Copy link
Copy Markdown

What does this PR do, and why?

Cancel image-download response bodies before reporting HTTP errors or unsupported content types. Preserve the original error if cancellation fails.

Linked issue

Fixes #984.

How did you verify it?

Windows, Bun 1.3.14:

  • Five regressions pass using the real tool, local HTTP and a Node HTTP-to-Web stream bridge.
  • Backend typecheck, changed-file formatting and gitleaks pass.
  • Broader tests hit existing Windows path/symlink failures; the path failure also reproduces on unchanged main.
  • Full bun run check and monorepo typecheck are blocked by an unchanged tracked symlink checked out as text. Later full-check stages have not run; full verification still needs Linux CI.

Checklist

  • bun run check is green (Windows limitation above)
  • CHANGELOG.md has an Unreleased entry
  • No version bumps

@vercel

vercel Bot commented Oct 16, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the InkVell Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image-result download leaves the response stream open after HTTP errors

1 participant