Conversation
Hard-waiting on BackgroundPaymentsIntro-later flakes the Android send shard when the timed sheet is already gone or auto-dismissed. Poll like waitForToastBestEffort and still dismiss Later/Cancel when the intro is shown. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
9 tasks
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 9b95a97)
Collaborator
|
Closing this empty same-branch companion. It had 0 file changes vs Closing + deleting the branch so |
Collaborator
|
Closing empty companion; see above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion branch for synonymdev/bitkit-android#1292 (
fix/901-block-own-invoice), so the local e2e job resolves a matching branch here.Same commit as the other companions on this batch (#234, #236, #237, #238, #239, #240, #241):
dismissBackgroundPaymentsTimedSheetpolls for the sheet and swallows the timeout when it never appears, instead of failing the spec.Without it, the
settingsshard on #1292 fails@settings_01and@settings_06withDrawerSettings still not displayed after 30000ms— the intro sheet sits over the home screen and swallows the drawer tap. The Android PR itself only adds a self-payment guard in the send flow and does not touch settings or the drawer.