Skip to content

test: dismiss confirmed-only receive sheet in boost_1 - #230

Closed
jvsena42 wants to merge 1 commit into
mainfrom
test/dismiss-confirmed-only-receive-boost1
Closed

jvsena42 wants to merge 1 commit into
mainfrom
test/dismiss-confirmed-only-receive-boost1

Conversation

@jvsena42

Copy link
Copy Markdown
Member

Companion of synonymdev/bitkit-android#1299
Part of synonymdev/bitkit-android#797

@boost_1 - Can do CPFP restores the wallet from seed, reinstalls, and only then mines the block that confirms the boosted receive. The restored wallet never saw that transaction in the mempool, so on synonymdev/bitkit-android#1299 the confirmation is its first sight of the deposit and the received sheet opens over the screen. The next step is doNavigationClose(), which fails with element ("...resourceId("HeaderMenu")") still not displayed after 30000ms.

The sheet is correct there: the wallet really did receive a transaction it had not seen before, and the restore has already finished, so neither the restore guard nor the one-hour block-timestamp guard applies. The spec is what needs to change.

This PR:

  1. Adds dismissReceivedPaymentIfShown() to test/helpers/actions.ts, a tolerant wrapper around acknowledgeReceivedPayment() that returns false instead of throwing when no sheet appears.
  2. Calls it in @boost_1 between mineBlocks(1) and doNavigationClose().

The helper is tolerant on purpose: iOS does not notify confirmed-only receives yet (synonymdev/bitkit-ios#455), and neither does Android master, so the same spec has to pass with and without the sheet. acknowledgeReceivedPaymentIfPresent() could not be reused as is, because it is strict on the local backend that this shard runs on.

@boost_2 - Can do RBF also restores and mines, and is left alone: the block there confirms the outgoing RBF transaction, and the incoming 100k was already confirmed before the restore, so no confirmed-only receive follows the restore. It passes on synonymdev/bitkit-android#1299 today.

Not run locally: the change adds one helper call and a helper that only wraps an existing one in try/catch. test/specs/boost.e2e.ts is prettier-clean; test/helpers/actions.ts had pre-existing prettier warnings before this change and the added block is formatted to the repo config.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@jvsena42

Copy link
Copy Markdown
Member Author

Superseded by #231, same commit on a branch named after the app branch so determine-e2e-branch picks it up on synonymdev/bitkit-android#1299.

@jvsena42 jvsena42 closed this Sep 17, 2026
@jvsena42
jvsena42 deleted the test/dismiss-confirmed-only-receive-boost1 branch September 17, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant