Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Align settings_01 / settings_06 with the #232 waitForToastBestEffort pattern so a missed or overlaying BalanceUnitSwitchedToast / BalanceHiddenToast does not fail openSettings (DrawerSettings) after TotalBalance. UI unit text and ShowBalance remain the source of truth. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 9b95a97)
Hard-waiting on BackgroundPaymentsIntro-later flakes the Android send shard when the timed sheet is already gone or auto-dismissed. Poll like waitForToastBestEffort and still dismiss Later/Cancel when the intro is shown. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com> (cherry picked from commit fe1e0fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of synonymdev/bitkit-android#809
Companion of synonymdev/bitkit-android#1280
This PR:
NavigationBacktap afterTransferSuccess-buttonin the channel close test intransfer.e2e.tsdoNavigationClose()afterTransferSuccess-buttonintransferSpendingToSavings()synonymdev/bitkit-android#1280 sends OK on the transfer-to-savings success screen to Home, the same as iOS. After that change there is no Spending screen to leave, so both steps fail on Android. Merge this together with synonymdev/bitkit-android#1280; against current Android master these two steps are still needed.
Not run locally: the change only deletes lines, and
doNavigationCloseanddriverare still used elsewhere in both files. The Android flow itself was verified by hand on an emulator build of #1280 (OK lands on Home, system back exits to the launcher).