-
Notifications
You must be signed in to change notification settings - Fork 5
fix: show first-time balance gesture toasts #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pwltr
wants to merge
3
commits into
master
Choose a base branch
from
codex/first-balance-gesture-toasts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a companion
bitkit-e2e-testsbranch or thesettingssuite stays red.The spec already waits for and dismisses both of these toasts — but only on iOS, because when these toasts shipped on iOS, Android didn't have them. Now Android emits the same test tags and the guards are stale.
bitkit-e2e-testsmain(30d5f98),test/specs/settings.e2e.ts:So on Android the toast is never dismissed, and the next step is
openSettings()at:52/:215, which iswaitForDisplayed('HeaderMenu')→sleep(500)→sleep(200)→ a singleclick().ToastOverlayis afillMaxSizeBox atAlignment.TopCenter, mounted inMainActivity.kt:200after the nav content, so itspointerInputnode is the topmost sibling and shadowsHeaderMenuin the top band. The click lands on the toast.The 5s auto-hide does not rescue it, which is the part worth being explicit about: the toast does expire, but
openSettingsonly clicks once and then waits 30s forDrawerSettingswith no re-tap. So the drawer never opens and the wait times out. The failure screenshot shows exactly that — Home with$ 0.00(the unit did switch), no toast, drawer closed.Evidence it's this PR and not flake — run 34992953927, job 104463600597, all three attempts identical:
Every other test in the suite that calls
openSettings(03, 04, 05, 07, 09, 10, 11) passes, so the drawer is fine — only the two tests that trigger these toasts fail. The same job is green today on five other PR branches and on master.That run is against
e2f61e95. Head0cae3c667keepsshowFirstHideToast = trueonHomeScreen.kt:647and doesn't touchswitchBalanceUnit, so the in-flight run 34995922345 should fail the same way.Fix: push a
bitkit-e2e-testsbranch named exactlycodex/first-balance-gesture-toastsdropping the twoif (driver.isIOS)wrappers — keep thewaitForToastcalls, they're already platform-agnostic and the tags now exist on both apps.determine-e2e-branchdoesgit ls-remote --exit-codeon the app branch name and falls back tomain, so it'll pick that up automatically on the next run; merge it alongside this PR. I confirmed no such branch exists today.Two things I'd avoid: gating the toasts on
Env.isE2eTest(removes the only assertion that proves the feature works, and diverges e2e builds from what ships), and a blanket "dismiss any toast" inopenSettings(broader than needed, and it would mask future overlay regressions).Unrelated: the red
lightning_securityjob is infra —failed to bind host port 0.0.0.0:39388 … address already in useduring regtest setup, before any test ran.