Allow configuring the Symfony AI and UX versions used in class links#206
Open
Amoifr wants to merge 1 commit into
Open
Allow configuring the Symfony AI and UX versions used in class links#206Amoifr wants to merge 1 commit into
Amoifr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:class:directive supports Symfony AI (#196) and Symfony UX (#198) classes, but the generated URLs have their versions hardcoded tomainand2.xinClassReference. This makes them configurable, following the same pattern as the Symfony version.BuildConfiggains two versions, defaulting to the current values, so nothing changes unless you opt in:The two URLs become placeholder constants (like
SYMFONY_REPOSITORY_URL),ClassReferencereceives them instead of hardcoding the branches, andKernelFactory— its only instantiation site — passes them along.About the tests:
blocks/references/classfixture passes untouched, which shows the defaults preserve the current output;Symfony\AI\AiBundle→ai-bundle);ClassReferencemakes exactly the 3 configured AI/UX cases fail, while the Symfony one and the defaults stay green.One thing I noticed while tracing the wiring, and deliberately left alone:
Application::__construct()takes$symfonyVersionbut never passes it toBuildConfig, so the--symfony-versionCLI option looks like it has no effect. That's a separate matter — happy to open an issue if you'd like.Fixes #199
Thanks for maintaining the tooling that keeps the docs building. 🙂