Add the missing security Twig functions to the dummy extension - #57
Open
Amoifr wants to merge 1 commit into
Open
Add the missing security Twig functions to the dummy extension#57Amoifr wants to merge 1 commit into
Amoifr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While documenting the
access_decision()Twig functions in symfony/symfony-docs#22452, theCode Blockscheck failed with:The functions do exist (they are registered by
Symfony\Bridge\Twig\Extension\SecurityExtension), but they are missing fromDummyExtension, so any new Twig code block using them is reported as invalid.Comparing
SecurityExtension::getFunctions()withDummyExtension, 5 of its 8 functions were missing:is_granted_for_useraccess_decisionaccess_decision_for_userimpersonation_pathimpersonation_urlThree of them (
is_granted_for_user,impersonation_path,impersonation_url) are already documented inreference/twig_reference.rst; they go unnoticed today only because their code blocks predate the baseline.The added test fails on
main(1 issue reported) and passes with this change.Thanks a lot for maintaining this tool — it caught a real mistake of mine in the very same PR, so I'm happy to give a little back. 🙂