Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Optimizer/FuncCallOptimizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,13 @@ protected function dispatchBigType(
$args[] = $this->parseOrderedOperand($expr->args[1]->value, false);
}

// PHP abs(PHP_INT_MIN) returns a float. The scalar PHPX overload
// cannot represent that value-dependent return type, so route static
// integers through the Variant overload, which preserves it.
if ($target === 'php::fn::abs' && $type === Type::INT) {
return $target . '(php::Variant(' . $args[0] . '))';
}

return $target . '(' . implode(', ', $args) . ')';
}

Expand Down
2 changes: 1 addition & 1 deletion tests/compiler/static/static_prop_write.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ function main() {
}
?>
--EXPECT--
string(4) "init"
string(27) "{closure:Worker::init():18}"
43 changes: 36 additions & 7 deletions tests/compiler/stdlib/abs_edge.phpt
Original file line number Diff line number Diff line change
@@ -1,16 +1,45 @@
--TEST--
abs edge cases: PHP_INT_MIN and -0.0
abs edge cases preserve PHP_INT_MIN's float result on static integer paths
--FILE--
<?php
$value = std::any(PHP_INT_MIN);
var_dump(abs($value));
var_dump(abs(-0.0));
var_dump(abs(0));
var_dump(abs(-5));
var_dump(abs(3.14));
function typed_abs(int $value): int|float
{
return abs($value);
}

function next_value(int $value, int &$calls): int
{
$calls++;
return $value;
}

function main(): void
{
$minimum = PHP_INT_MIN;
$absoluteMinimum = abs($minimum);
var_dump($absoluteMinimum);
var_dump(typed_abs(PHP_INT_MIN));
var_dump(typed_abs(-42));

$calls = 0;
var_dump(abs(next_value(PHP_INT_MIN, $calls)));
var_dump($calls);

$value = std::any(PHP_INT_MIN);
var_dump(abs($value));
var_dump(abs(-0.0));
var_dump(abs(0));
var_dump(abs(-5));
var_dump(abs(3.14));
}
?>
--EXPECT--
float(9.223372036854776E+18)
float(9.223372036854776E+18)
int(42)
float(9.223372036854776E+18)
int(1)
float(9.223372036854776E+18)
float(0)
int(0)
int(5)
Expand Down
Loading