Skip to content

feat(codegen): GameEventsGenerator add FieldOverrides #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skuzzis merged 2 commits into from
Apr 26, 2026
+69 −7
Merged

feat(codegen): GameEventsGenerator add FieldOverrides #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdbe66f
feat(codegen): GameEventsGenerator add FieldOverrides
isMADAO Apr 25, 2026
f8a26ce
update(codegen): keep original property as obsolete, add Actual* for …
isMADAO Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 69 additions & 7 deletions src/CS2/Generators/GameEventsGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ public class GameEvents : BaseGenerator
{ "ehandle", ("nint", "Ptr", true, null) }
};

/// <summary>
/// Force a specific C# type for a given event field, overriding the type declared in the .gameevents file.
/// </summary>
private static readonly Dictionary<(string Event, string Field), (string CsType, string Accessor, bool CanSet, string? CastKind)> FieldOverrides = new()
{
{ ("player_hurt", "health"), ("int", "Int", true, null) },
{ ("player_hurt", "armor"), ("int", "Int", true, null) },
{ ("player_hurt", "dmg_health"), ("int", "Int", true, null) },
{ ("player_hurt", "dmg_armor"), ("int", "Int", true, null) },
{ ("player_hurt", "hitgroup"), (CS2SchemaType.HitGroup_t, "Int", true, CS2SchemaType.HitGroup_t) },

{ ("player_death", "dmg_health"), ("int", "Int", true, null) },
{ ("player_death", "dmg_armor"), ("int", "Int", true, null) },
{ ("player_death", "hitgroup"), (CS2SchemaType.HitGroup_t, "Int", true, CS2SchemaType.HitGroup_t) },
};

private static readonly HashSet<string> SkipTypes = new() { "none", "local" };

private static readonly Regex EventNameRegex = new(@"^\s*""([^""]+)""");
Expand Down Expand Up @@ -362,7 +378,7 @@ private void GenerateInterface(GameEventDef ev, string outputDir)
});

var filePath = Path.Combine(outputDir, $"{typeName}.cs");
File.WriteAllText(filePath, writer.GetCode() + "\n");
File.WriteAllText(filePath, writer.GetCode("\r\n") + "\r\n");
}

private void GenerateClass(GameEventDef ev, string outputDir)
Expand Down Expand Up @@ -393,7 +409,7 @@ private void GenerateClass(GameEventDef ev, string outputDir)
});

var filePath = Path.Combine(outputDir, $"{typeName}Impl.cs");
File.WriteAllText(filePath, writer.GetCode() + "\n");
File.WriteAllText(filePath, writer.GetCode("\r\n") + "\r\n");
}

private void RenderHeaderComment(CodeWriter writer, GameEventDef ev)
Expand Down Expand Up @@ -421,11 +437,12 @@ private void RenderInterfaceFields(CodeWriter writer, GameEventDef ev)
continue;
}

if (!TypeMap.TryGetValue(ftype, out var typeInfo))
if (!TypeMap.TryGetValue(ftype, out var defaultInfo))
continue;

var (csType, _, canSet, _) = typeInfo;
var (csType, _, canSet, _) = defaultInfo;
var propName = GetUniquePropName(ToPropertyName(fname), usedPropNames);
var hasOverride = FieldOverrides.TryGetValue((ev.Name, fname), out var ov);

writer.AddLine();
writer.AddLine("/// <summary>");
Expand All @@ -435,8 +452,32 @@ private void RenderInterfaceFields(CodeWriter writer, GameEventDef ev)
writer.AddLine("/// <br/>");
}
writer.AddLine($"/// type: {ftype}");
if (hasOverride)
{
writer.AddLine("/// <br/>");
writer.AddLine($"/// See <see cref=\"Actual{propName}\"/>.");
}
writer.AddLine("/// </summary>");
if (hasOverride)
writer.AddLine($"[Obsolete(\"The declared type may not match the actual value. Use Actual{propName} instead.\")]");
writer.AddLine($"{csType} {propName} {{ get; {(canSet ? "set; " : "")}}}");

if (hasOverride)
{
var (ovCsType, _, ovCanSet, _) = ov;
var actualName = GetUniquePropName($"Actual{propName}", usedPropNames);

writer.AddLine();
writer.AddLine("/// <summary>");
if (!string.IsNullOrEmpty(fdef.Comment))
{
writer.AddLine($"/// {fdef.Comment}");
writer.AddLine("/// <br/>");
}
writer.AddLine($"/// type: {ovCsType}");
writer.AddLine("/// </summary>");
writer.AddLine($"{ovCsType} {actualName} {{ get; {(ovCanSet ? "set; " : "")}}}");
}
}
}

Expand Down Expand Up @@ -500,13 +541,13 @@ private void RenderClassFields(CodeWriter writer, GameEventDef ev)
continue;
}

if (!TypeMap.TryGetValue(ftype, out var typeInfo))
if (!TypeMap.TryGetValue(ftype, out var defaultInfo))
continue;

var (csType, accessor, canSet, castKind) = typeInfo;
var (csType, accessor, canSet, castKind) = defaultInfo;
var propName = GetUniquePropName(ToPropertyName(fname), usedPropNames);

var (getter, setter) = BuildAccessors(fname, accessor, castKind);
var hasOverride = FieldOverrides.TryGetValue((ev.Name, fname), out var ov);

writer.AddLine();
if (!string.IsNullOrEmpty(fdef.Comment))
Expand All @@ -516,6 +557,22 @@ private void RenderClassFields(CodeWriter writer, GameEventDef ev)
writer.AddLine($"{{ get => {getter}; set => {setter}; }}");
else
writer.AddLine($"{{ get => {getter}; }}");

if (hasOverride)
{
var (ovCsType, ovAccessor, ovCanSet, ovCastKind) = ov;
var actualName = GetUniquePropName($"Actual{propName}", usedPropNames);
var (ovGetter, ovSetter) = BuildAccessors(fname, ovAccessor, ovCastKind);

writer.AddLine();
if (!string.IsNullOrEmpty(fdef.Comment))
writer.AddLine($"// {fdef.Comment}");
writer.AddLine($"public {ovCsType} {actualName}");
if (ovCanSet && ovSetter != null)
writer.AddLine($"{{ get => {ovGetter}; set => {ovSetter}; }}");
else
writer.AddLine($"{{ get => {ovGetter}; }}");
}
}
}

Expand Down Expand Up @@ -564,6 +621,7 @@ private void RenderClassPlayerField(CodeWriter writer, string fname, EventField
"Bool" => ($"Accessor.GetBool(\"{fname}\")", $"Accessor.SetBool(\"{fname}\", value)"),
"Int" when castKind == "byte" => ($"(byte)Accessor.GetInt32(\"{fname}\")", $"Accessor.SetInt32(\"{fname}\", value)"),
"Int" when castKind == "short" => ($"(short)Accessor.GetInt32(\"{fname}\")", $"Accessor.SetInt32(\"{fname}\", value)"),
"Int" when castKind != null => ($"({castKind})Accessor.GetInt32(\"{fname}\")", $"Accessor.SetInt32(\"{fname}\", (int)value)"),
"Int" => ($"Accessor.GetInt32(\"{fname}\")", $"Accessor.SetInt32(\"{fname}\", value)"),
"Uint64" => ($"Accessor.GetUInt64(\"{fname}\")", $"Accessor.SetUInt64(\"{fname}\", value)"),
"Float" => ($"Accessor.GetFloat(\"{fname}\")", $"Accessor.SetFloat(\"{fname}\", value)"),
Expand Down Expand Up @@ -674,6 +732,10 @@ public EventField(string name, string typeName, string comment)
}
}

internal static class CS2SchemaType {
public const string HitGroup_t = "HitGroup_t";
}

internal class GameEventDef
{
public string Name { get; }
Expand Down