Repository navigation
Cache Swiftly Update Checking - #616
Merged
Merged
Conversation
We don't need to check for a Swiftly update on every invocation. Relax the check to only check every 24 hours. A `swiftly self-update` always checks for an update, so it will always bump the last-checked time. In the other cases, we only re-check after 24 hours since the last time we check.
etcwilde
requested review from
cmcgee1024,
justice-adams-apple and
shahmishal
as code owners
November 3, 2026 07:15
cmcgee1024
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to check for a Swiftly update on every invocation. Relax the check to only check every 24 hours. A
swiftly self-updatealways checks for an update, so it will always bump the last-checked time. In the other cases, we only re-check after 24 hours since the last time we checked.This strikes a balance between entirely disabling the version check and checking on every Swiftly invocation.
Reported as an issue with the VSCode plugin: https://forums.swift.org/t/vscode-swift-hits-network-every-2s-via-swiftly/90352.