Repository navigation
Avoid installing a new toolchain on self-update - #610
Merged
Merged
Conversation
A Swiftly self-update runs `swiftly init` afterward to install itself and configure everything. Unlike on the initial installation, a self-update indicates that Swiftly was already installed and configured. If someone explicitly specified that they didn't want to install a toolchain or modify their profile when they first installed Swiftly, an update shouldn't ignore that do it anyway. Stop modifying the profile to source the env.sh and stop trying to install the latest toolchain on a Swiftly self-update.
etcwilde
requested review from
cmcgee1024,
justice-adams-apple and
shahmishal
as code owners
October 14, 2026 22:24
justice-adams-apple
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Swiftly self-update runs
swiftly initafterward to install itself and configure everything. Unlike on the initial installation, a self-update indicates that Swiftly was already installed and configured. If someone explicitly specified that they didn't want to install a toolchain or modify their profile when they first installed Swiftly, an update shouldn't ignore that do it anyway.Stop modifying the profile to source the env.sh and stop trying to install the latest toolchain on a Swiftly self-update.