Repository navigation
Add Ubuntu 26.04 and Debian 13 to the PR checks - #585
Merged
cmcgee1024 merged 14 commits intoSep 26, 2026
Merged
Conversation
shahmishal
reviewed
Sep 15, 2026
| fail-fast: false | ||
| matrix: | ||
| container: ["swiftlang/swift:nightly-6.3-fedora41"] | ||
| container: ["swiftlang/swift:nightly-6.3-fedora41", "swiftlang/swift:nightly-6.3-resolute", "swiftlang/swift:nightly-6.3-trixie"] |
Member
There was a problem hiding this comment.
We should switch over to official release of 6.4.0
…ations instead of 6.3
…pr_check_ubuntu26_debian13
Handle missing bitcode_strip that Swift Build expects in the CommandLineTools
cmcgee1024
marked this pull request as ready for review
September 24, 2026 23:08
cmcgee1024
requested review from
etcwilde and
justice-adams-apple
as code owners
September 24, 2026 23:08
etcwilde
approved these changes
Sep 26, 2026
| arguments: ["--version"], | ||
| output: .discarded | ||
| ) | ||
| var gpgIsMissing = false |
Member
There was a problem hiding this comment.
definite initialization should allow you to defer assigning to a let so long as you've assigned it before use:
let gpgIsMissing: Bool
do {
let result = try await run(
.name("gpg"),
arguments: ["--version"],
output: .discarded
)
gpgIsMissing = !result.terminationStatus.isSuccess
} catch let error as SubprocessError where error.code == .executableNotFound {
gpgIsMissing = true
}Then we can make it immutable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.