Support JDK17 style code snippets; {@snippet is only since JDK18#702
Merged
ktoso merged 1 commit intoswiftlang:mainfrom Apr 14, 2026
Merged
Support JDK17 style code snippets; {@snippet is only since JDK18#702ktoso merged 1 commit intoswiftlang:mainfrom
ktoso merged 1 commit intoswiftlang:mainfrom
Conversation
This caught me off guard but it seems only JDK18 has the `{@snippet}`
style code snippets, and was introduced in https://openjdk.org/jeps/413
So in order to not fail JDK17 javadoc we now allow building with
explicit JDK 17 source level target and skip this new style.
Eventually we'll support `///` javadoc as well
ktoso
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caught me off guard but it seems only JDK18 has the
{@snippet}style code snippets, and was introduced in https://openjdk.org/jeps/413So in order to not fail JDK17 javadoc we now allow building with explicit JDK 17 source level target and skip this new style.
Eventually we'll support
///javadoc as well