Fix Java package mapping for dependent modules#699
Merged
ktoso merged 14 commits intoswiftlang:mainfrom Apr 16, 2026
Merged
Conversation
Pass dependency module-to-package metadata through the Swift-to-Java pipeline and use it when translating nominal Java types. This preserves package names for classes coming from dependent modules instead of emitting them without a package.
iDevid
changed the title
ktoso
reviewed
Apr 14, 2026
ktoso
reviewed
Apr 14, 2026
Collaborator
|
Some requests inline, thanks! |
Contributor
Author
|
Thanks for the feedbacks @ktoso |
sidepelican
reviewed
Apr 15, 2026
…ix/java-dependency-mapping
…alifiedClassName!
ktoso
approved these changes
Apr 16, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looks good now, thank you.
I've fixed the formatting issue and pushed
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to preserve the mapping between dependent Swift modules and their Java packages so JNI generation can resolve cross-module Java references correctly.
While doing that, I also replaced tuple-based dependent-config plumbing with named structures to make the data flow clearer and less error-prone.
A concrete example of this setup can be found in TriForce: https://github.com/iDevid/TriForce
In that sample project, the Android app depends on SharedNetworkLayer, which in turn depends on SharedModels.