Repository navigation
Add withByteArrayElements and newByteArray(_:) for Java byte[] - #27
Open
piercifani wants to merge 1 commit into
Open
piercifani wants to merge 1 commit into
piercifani wants to merge 1 commit into
Conversation
Bridging binary payloads (Data, [UInt8]) to and from byte[] is the common case where copying through a Swift array first costs real time and memory. jni-core's Array JavaValue conversions copy element-wise into a Swift array; libraries that need direct access drop to the raw Get/ReleaseByteArrayElements functions and their release-mode constants. - withByteArrayElements(_:releaseMode:_:): scoped access to the elements, released with the chosen JavaArrayReleaseMode. - newByteArray(_:): a byte[] filled from an UnsafeRawBufferPointer with one SetByteArrayRegion call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Binary payloads (
Data,[UInt8]) are where copying through a Swift array first costs real time and memory. jni-core'sArrayJavaValueconversions copy element by element. Libraries that need direct access fall back to the rawGet/ReleaseByteArrayElementsfunctions and their barejintrelease-mode constants.Change
JavaArrayReleaseMode:.copyBackAndRelease(0),.copyBack(JNI_COMMIT),.discard(JNI_ABORT).JNIEnvironment.withByteArrayElements(_:releaseMode:_:): scoped access to the elements, released in the chosen mode. The default,.discard, is right for read-only access.JNIEnvironment.newByteArray(_ bytes: UnsafeRawBufferPointer) -> jbyteArray?: oneNewByteArray+SetByteArrayRegion.This covers only
byte[], the case with real demand. Other primitive types can follow the same shape if needed.Tests
ByteArrayTests:.copyBackAndReleasewrites changes back to the Java array.Results:
swift:6.4.2-noble, OpenJDK 17)🤖 Generated with Claude Code