WiX: Allow arbitrary signing command - #554
Open
speednoisemovement wants to merge 2 commits into
Open
Conversation
speednoisemovement
requested review from
compnerd,
etcwilde and
shahmishal
as code owners
July 28, 2026 22:03
This introduces a new property `SignCommand` which allows overriding the full command used to code sign. If not provided, we fall back to the explicit `CERTIFICATE/PASSPHRASE` flow. This removes Azure Artifact/Trusted Signing as a first-class option, but it can still be used via the `SignCommand` override.
speednoisemovement
changed the title
compnerd
reviewed
Jul 29, 2026
|
|
||
| <Exec Condition="'$(SignOutput)' == 'true'" | ||
| Command="$(SignTool) "%(_RuntimeWin32Assembly.Catalog)"" /> | ||
| Command="$(SignCommand) "%(_RuntimeWin32Assembly.Catalog)"" /> |
Member
There was a problem hiding this comment.
I don't understand this change
Contributor
Author
There was a problem hiding this comment.
Renaming to be more accurate (it's the whole command, not just the tool)
Member
There was a problem hiding this comment.
Can we split that out into a separate change? I think that we should have three changes:
- rip out the old azure signing
- replace the command
- add in the new hook point
Contributor
Author
There was a problem hiding this comment.
replace the command
Which? Do you just mean the rename? There's NFC for the cert/passphrase path here (beyond the ability to override it)
Contributor
Author
| Text="Unable to locate signtool.exe. Set SignToolPath to the Windows SDK bin directory." /> | ||
|
|
||
| <PropertyGroup> | ||
| <SignCommand Condition=" '$(SignCommand)' == '' ">"$(SignToolPath)signtool.exe" sign $(VerboseFlag)/tr http://timestamp.digicert.com /fd sha256 /td sha256 /f "$(CERTIFICATE)" /p "$(PASSPHRASE)"</SignCommand> |
Member
There was a problem hiding this comment.
Oh, this changes the time server - why?
Contributor
Author
There was a problem hiding this comment.
It's the previous non-trusted signing arm, same server:
<SignTool Condition=" '$(AzureSignMetadata)' == '' ">"$(SignToolPath)signtool.exe" sign $(VerboseFlag)/tr http://timestamp.digicert.com /fd sha256 /td sha256 /f "$(CERTIFICATE)" /p "$(PASSPHRASE)" </SignTool>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new property
SignCommandwhich allows overriding the full command used to code sign. If not provided, we fall back to the explicitCERTIFICATE/PASSPHRASEflow.Also removes Azure Artifact/Trusted Signing as a first-class option, but it can still be used via the
SignCommandoverride.