WiX: Conditionally package LLVM.dll - #516
Conversation
Steelskin
changed the title
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
I think that this is fine - we will eventually want to remove this option, but it makes sense to have this as a transition thing.
Yes, I intend to eventually remove it. I mostly want to have it around in case we need to revert enabling the DLL build. |
This adds a new configuration option to conditionally package LLVM.dll. The effort to build LLVM as a DLL on Windows is tracked in swiftlang/swift#85241.
09b77f2 to
86c4c20
Compare
|
@compnerd Could you take another look, please? This is still a no-op. |
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
The change itself seems fine, please do a cross-repo test and share the results. Ideally with and without the DLL builds.
I did a Windows toolchain build without the DLL build in swiftlang/swift#90268. it passed: https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/6630/ |
2 participants
This adds a new configuration option to conditionally package LLVM.dll.
The effort to build LLVM as a DLL on Windows is tracked in swiftlang/swift#85241.