Repository navigation
Switch to lazily performing capture transforms - #917
Draft
natecook1000 wants to merge 1 commit into
Draft
natecook1000 wants to merge 1 commit into
natecook1000 wants to merge 1 commit into
Conversation
Stored captures now hold only a range plus indices into a per-attempt value table, so the capture undo log has no reference counting. Capture transforms run once the match is complete; failable (TryCapture) transforms still run during matching to decide whether to backtrack, and their result is cached in the table. Custom matcher values live there too.
natecook1000
marked this pull request as draft
November 11, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes stored captures to hold only a range plus an index into a per-attempt value table, so that the undo logs have no reference counting. Custom matchers and their transforms, along with
TryCapturetransforms, still run during matching and cache their result in a register array. All other transforms are performed post-successful match.