Repository navigation
Don't set the minimum Swift version floor at the patch level - #350
Merged
Merged
Conversation
A manifest with `swift-tools-version: 6.2.3` produced a floor of `6.2.3`, while the `6.2` version label orders as `6.2.0`. The filter then skipped Swift 6.2 even though the `6.2` toolchain satisfies that tools version. Changed: * Truncated the floor in `MinimumVersion` to its major and minor components. * Added tests for a patch tools version and a patch `minimum_swift_version`. Result: * A patch-level minimum keeps its own minor release in the matrix.
javawithjiva
approved these changes
Nov 10, 2026
FranzBusch
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manifest with
swift-tools-version: 6.2.3produced a floor of6.2.3, while the6.2version label orders as6.2.0. The filter then skipped Swift 6.2 even though the6.2toolchain satisfies that tools version.Changed:
MinimumVersionto its major and minor components.minimum_swift_version.Result: