Do not re-schedule request head timeout for HTTP/2 and HTTP/3 - #108
Merged
Conversation
gjcairo
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, in
RequestTimeoutHandler, we reschedule the request timeout after seeing the request end part so that the timeout is ready for the next request on the channel:swift-http-server/Sources/NIOHTTPServer/TimeoutHandlers.swift
Lines 133 to 136 in c2e1f5a
However, this is only really necessary for HTTP/1. For HTTP/2 and HTTP/3, there can only ever be one request on a stream channel, so we do not need to reschedule the header timeout.
Avoiding this re-scheduling also means we can avoid the cost of cancelling the re-scheduled task (which is not required in the first place) when the handler is imminently removed after the request has finished.
Modifications
Introduced a new boolean flag named
expectMultipleRequeststoRequestTimeoutHandler. WhenexpectMultipleRequests == false, the header timeout is not rescheduled after receiving a request end part.Result
Unnecessary creation and cancellation of tasks avoided.