add proxy-header support - #912
Merged
Merged
Conversation
Motivation: when connecting via HTTP proxy, allow users to set HTTP headers on the CONNECT request to the proxy. This is useful for attribution purposes. Modifications: - adds a `connectHeaders` parameter to HTTPClient.Configuration - parses `connectHeaders` swift-configuration property as list of colon-separated `key: value` pairs - sets proxy headers on CONNECT request Result: implements proxy-header support
benrobby
force-pushed
the
proxy-connect-headers
branch
from
July 23, 2026 07:22
b41c2bc to
777e3ee
Compare
glbrntt
reviewed
Jul 23, 2026
glbrntt
left a comment
glbrntt
left a comment
Collaborator
There was a problem hiding this comment.
LGTM module a couple of nits
added 2 commits
July 23, 2026 13:04
glbrntt
reviewed
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
when connecting via a HTTP proxy, this now allows users to set HTTP headers on the CONNECT request to the proxy. This is useful for caller attribution purposes.
Modifications:
connectHeadersparameter to HTTPClient.ConfigurationconnectHeadersswift-configuration property as list of colon-separatedkey: valuepairsResult:
implements proxy-header support