fix: resolve commands through the pull request endpoint - #79
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first live
/fix 1run on ritofactory/rito-mvp#29 failed with HTTP 403 before planning: command preparation fetched/issues/29, but its job deliberately grantspull-requests: readwithoutissues: read.Resolve the PR directly through
/pulls/{number}, which supplies all required metadata and establishes that the issue number belongs to a PR. Treat 404 as an inaccessible/non-PR refusal, while other HTTP errors remain operational failures. This removes the redundant API request without expanding workflow permissions.The test fixture now denies issue-endpoint access, reproducing the live permission boundary. Regression coverage also checks that 404 refuses and 401/403/500 stop preparation without being mislabeled as non-PRs.
Validation: 220 focused tests and type checking pass. Read-only preparation using PR #29’s real review artifact succeeds (local lookup supplies the observed Actions bot identity because the local token identifies a user). Full deterministic suite: 2,311 passed, 2 skipped.
Live failure: https://github.com/ritofactory/rito-mvp/actions/runs/35086570565