fix: carry pr draft status into remediation approval - #78
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/fixworkflow handlesissue_commentevents, which contain no PR draft status. Its approval assertion therefore treats even trusted authors’ non-draft PRs as drafts and refuses fixes in repositories without required environment reviewers.Resolve draft status from the PR API during command preparation and pass it to both job routing and the in-job approval assertion. Only literal API
falsepermits a trusted author to bypass approval; draft, missing, and malformed values still require it.Validation: regression coverage combines author trust with draft states and checks the workflow wiring. GitHub CI passes the full deterministic suite and type checking. Locally, 2,304 tests passed and 2 skipped; four socket-server tests blocked by the sandbox passed on a rerun of all 45 GitHub API tests outside the sandbox. Workflow lint passes with only the installed actionlint version’s missing support for the existing
job.workflow_shaandjob.workflow_repositoryfields excluded.