Skip to content

test: live query teardown - #16849

Draft
elliott-with-the-longest-name-on-github wants to merge 11 commits into
version-3from
elliott/elliott/live-query-teardown
Draft

test: live query teardown#16849
elliott-with-the-longest-name-on-github wants to merge 11 commits into
version-3from
elliott/elliott/live-query-teardown

Conversation

@elliott-with-the-longest-name-on-github

Copy link
Copy Markdown
Contributor

closes #


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 19, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 20bf6d1:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/20bf6d1d7e82d3f9b071507fa986b264df2f10fd

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16849

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 20bf6d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

void generator.return(undefined).catch(() => {});
}

return new Response(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restores the request-abort teardown from #16790. Without it, a platform that aborts the request without cancelling the response stream leaves the keep-alive timer enqueueing into an unread buffer forever, and a generator that throws AbortError on disconnect routes a 500 through handleError because open is still true.

Suggested change
return new Response(
event.request.signal.addEventListener('abort', () => teardown(true), { once: true });
return new Response(

Can push a test for the abort path if you take this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I don't know if I'm specifically against this. But should we treat the platform aborting the request without closing the response stream as a bug? That seems like something the platform should definitely be doing.

Comment thread packages/kit/src/runtime/server/remote-functions.js Outdated
Co-authored-by: Nic Polumeyv <nicolas.polum@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants