Skip to content

breaking: replace builder.generateManifest with builder.generateServer and builder.getManifest - #16843

Open
ottomated wants to merge 7 commits into
version-3from
adapter-generateServer
Open

breaking: replace builder.generateManifest with builder.generateServer and builder.getManifest#16843
ottomated wants to merge 7 commits into
version-3from
adapter-generateServer

Conversation

@ottomated

Copy link
Copy Markdown
Contributor

alternative to #16827

Removes SSRManifest as a public api. Previously, adapters were using it directly; now they have a more limited api that mirrors $app/manifest. This ends up simplifying the code that adapters have to generate, because they only have to worry about a single server module vs server + manifest. It also removes the need for manifest._.foo in the internal code, which is nice.

Technically, SSRManifest is still used by some adapters (search server.manifest to find the uses). I don't know if we want to go all the way here and replace those with, i.e. rolldown defines?


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 18, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from da22759:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/da2275909f014dd1efbac7f9470532e5e95a0ecd

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16843

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: da22759

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sveltejs/adapter-cloudflare Major
@sveltejs/adapter-netlify Major
@sveltejs/adapter-node Major
@sveltejs/adapter-vercel Major
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

Netlify edge.js entry still uses the old new Server(manifest) API, so Server is undefined and the MANIFEST import is unresolved, breaking the edge function build.

Fix on Vercel

Comment thread packages/adapter-vercel/files/serverless.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant