breaking: replace builder.generateManifest with builder.generateServer and builder.getManifest - #16843
Open
ottomated wants to merge 7 commits into
Open
breaking: replace builder.generateManifest with builder.generateServer and builder.getManifest#16843ottomated wants to merge 7 commits into
builder.generateManifest with builder.generateServer and builder.getManifest#16843ottomated wants to merge 7 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/da2275909f014dd1efbac7f9470532e5e95a0ecdOpen in |
🦋 Changeset detectedLatest commit: da22759 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #16827
Removes
SSRManifestas a public api. Previously, adapters were using it directly; now they have a more limited api that mirrors$app/manifest. This ends up simplifying the code that adapters have to generate, because they only have to worry about a single server module vs server + manifest. It also removes the need formanifest._.fooin the internal code, which is nice.Technically, SSRManifest is still used by some adapters (search
server.manifestto find the uses). I don't know if we want to go all the way here and replace those with, i.e. rolldowndefines?Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.