chore: generate the env modules in a single pass - #16833
Open
Nic-Polumeyv wants to merge 2 commits into
Open
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/5f75e6400c6089ac0c791f0a2075605c5cafae5bOpen in |
🦋 Changeset detectedLatest commit: 5f75e64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
marked this pull request as draft
August 17, 2026 19:41
Nic-Polumeyv
force-pushed
the
env-generator-dedup
branch
from
August 19, 2026 04:14
fb0a917 to
5f75e64
Compare
Nic-Polumeyv
marked this pull request as ready for review
August 19, 2026 04:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core/env.jshad one generator per<sveltekit:generated>/env/*module, each iterating the same variables and callingvalidate()on the same static values, so a user's schema ran three to four times per build (and per hot update in dev), and a validator that isn't a pure function of its input baked different values intoconfig.js,public/server.jsandpublic/client.js.create_env_modulesreplaces them with a single pass over the variables that returns every module keyed by path, so the plugin only writes files. Dynamic variables are untouched; they were already validated once byset_env.One visible change: invalid variables that previously surfaced one module at a time are now reported in a single error.