Repository navigation
fix: capture included tool results that arrive as content blocks - #153
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
Agent and MCP tool results are stored in the transcript as an array of content blocks. cleanContent only accepts strings, so these results were dropped from captures even when the tool was listed in includeTools. Join their text blocks before cleaning and truncating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agent and MCP tool results are stored in the transcript as an array of content blocks instead of a string.
formatUserMessagepassesblock.contenttocleanContent, which returns an empty string for non-strings, so these results are dropped from the capture even when the tool is listed inincludeTools.Fix
getToolResultTextinplugin/hooks/lib/transcript.js. It returns string content unchanged and joins thetextblocks of array content. Image and other non-text blocks are skipped.Testing
test/unit.mjs:captures included tool results that arrive as content blocks. It runs the capture hook withincludeTools: ["Agent"]and a block-array tool result that contains a text block and an image block.npm testreports 33 passed, 1 failed (the new test).npm testreports 34 passed, 0 failed.npx biome ci .passes.Fixes #152