Repository navigation
chore(release): 0.1.13 migrate Claude hooks to API v5 - #138
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…ity mode Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ction Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This was referenced Oct 15, 2026
Contributor
There was a problem hiding this comment.
Review at bb7e944. The v5 migration holds up when run against local mock servers, but the version number blocks the release. Inline comments are below, ordered by severity.
Checked against main with mock servers:
- Legacy and custom-URL requests are byte-identical.
- Hosted v5 search keeps
searchMode:"memories", the 0.55 floor, top 5, no rerank/rewrite and 300-character excerpts. - Capture redacts before sending. It advances its cursor only after a confirmed
{id, status}, makes one request with no retries, and stalls end around 25s. - The vendored SDK rebuilds byte-for-byte from the lockfile and contains no secrets.
status.jsnever printed the key in 12 scenarios.- 32/32 tests pass on Node 24 and 18.0.0.
Not verified (needs hosted calls):
- Ranking parity between v5 and v4.
- v5
idappend compared with v3customIdupsert. - Hosted acceptance of tags that contain dots.
Draft #145 rewrites capture in the same files and will conflict with this PR.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Approving at 5c16c73. The review fixes are pushed as normal commits on top of a merge of main:
- Release values move to 0.1.13 in all five places, so 0.1.12 users get the update. The PR is retitled to match.
- The
SUPERMEMORY_NAMESPACEenv scope fallback is removed. The projectnamespacekey andSUPERMEMORY_REPO_TAGare unchanged. - On Node 18.0–18.13, a recall timeout (
cause.name === "AbortError") is now silent. Checked on 18.0.0 and 18.10.0. - The CI drift check now covers the whole
plugin/hooks/vendor/directory, including the LICENSE and any new files. - Dotted tags: hosted rejects them on every endpoint (mono
containerTagValidator), so the banner stays. The error now leads with the setting to rename.
Lint, the SDK bundle rebuild, and 32/32 tests pass on Node 24 and 18.20. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the official
supermemory@5.0.1SDK for hosted REST hooks: query-free SessionStart profiles, separate prompt memory search, and namespace-scoped capture POSTs. Search explicitly keeps memories mode, the 0.55 floor/top-five cap, no reranking/query rewriting, and existing 300-character excerpts. Profile object facts render as text; the recall mod and MCP tool protocol stay unchanged.Preserve existing installations: exact generated/overridden namespace identities, legacy config/env aliases, API-key precedence, separate REST/MCP/auth URLs, last-session data, and atomic JSON/pending/txt recovery. Custom REST URLs retain v3/v4 compatibility by default;
SUPERMEMORY_API_VERSION=v5or projectapiVersion: "v5"opts upgraded servers in. There is no automatic write/version fallback or hosted fallback. Capture translates the existing session ID to append/diffid, retains metadata/extraction context, disables SDK retries, keeps its 25-second budget, and rejects unconfirmed acceptance before advancing its cursor. Signal/tool/minimum behavior is unchanged.Ship a reproducible standalone SDK bundle and Apache-2.0 license inside
./plugin, so marketplace hooks need no user dependency installation. CI rebuilds the exact lockfile-pinned SDK/esbuild bundle and rejects any drift or new file underplugin/hooks/vendor/. All five release values advance to 0.1.13 (main already shipped 0.1.12 in #142); thechore(release):marker avoids a second automatic bump. Older release-only #133 remains untouched and must not downgrade this release.Verified without credentials, hosted API calls, or test-file changes:
These are client/runtime checks, not hosted historical-data migration, backend score/ranking parity, document append/dedup processing, or billing guarantees. Dynamic processing can delay recall. Existing cross-process duplicate uploads, cursor-loss edge cases, and acknowledgement/local-persistence ambiguity remain; no exactly-once claim or one-shot shutdown durability claim.
Review fixes through
5c16c73(on top of a merge of main at06cb43c): release values move to 0.1.13; theSUPERMEMORY_NAMESPACEenv scope fallback is removed because the bundledsupermemoryCLI uses that variable for its own default namespace (projectnamespace,repoContainerTag, andSUPERMEMORY_REPO_TAGare unchanged); a Node 18.0–18.13 recall timeout (cause.name === 'AbortError') is now silent like other timeouts. The invalid-scope error now leads with the setting to rename, so recall's 80-character banner shows it. Hosted rejects dots on every endpoint (monocontainerTagValidator), so a dotted tag has to be renamed, and the README now says so.Refreshed against main
8e98cb4after merged #144 ata043ead: the complete tree exactly matches independently reviewed native integration treedb4ee4f. Preserve main's opening-prompt/tool-turn grouping and corrected automatic-capture redaction/error sanitization; transcript, redactor and tests match current main byte-for-byte. Rechecked all 32 baseline tests, SDK rebuild/contracts, fresh 32-file cache, native cached two-turn/controlled-lag captures, and native multiline-password/URL-redaction captures with stable IDs. No new runner policy, test-file diff, release bump, or backend-parity claim.Focused review fixes at
1064436: selected v5 scopes are validated before any request against the documented charset and 1–100-character limit, with actionable override-key diagnostics that never echo the invalid value or mutate config/cursors. Explicit legacy dot-tag capture remains exact and opt-in where supported; historical hosted acceptance is unverified, and dot profile/search support is not claimed. Status404 preserves HTTP404, reports profile absent or route unsupported, and emits authenticated:null rather than inventing valid/bad credentials. Genuine200 profile access remains authenticated:true;401 remains false;403 remains permission denied with auth unknown.Existing32 tests, Node18/24 SDK/diagnostic sink probes, original config/pending/JSON/txt preservation, fresh cached native invalid-v5/no-request and explicit legacy-dot ACK sessions, and native status404 context all pass. Only README, status command guidance, API adapter and status script changed in this focused commit; no test/workflow/version/redactor diff. PLUG-65 independently verified exact
1064436; both issue findings and the inline thread are resolved, with no open scoped review issue. The remaining three notes are informational, not requests for code changes. Human approval and coordinated release-only #142 disposition remain separate gates; no merge is authorized.