Raise decrypt errors after recording persistent ids#14
Closed
cassiostp wants to merge 1 commit into
Closed
Conversation
Stop swallowing decryption failures in the push receiver client so library consumers still see authentication, missing crypto-key, and missing salt errors. The client still records the persistent id before raising so reconnects do not redeliver the same message. Also carries forward the existing GCM semicolon lint fix needed for yarn lint on master. CLI-801
cassiostp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_onDataMessagefrom warning and returning for decryption/auth failures that should be visible to library consumers.persistentIdbefore rethrowing those known errors so reconnects do not redeliver the same message.Requested from Brian's review on #13.