refactor: use Flaps CreateApp for app creation#4865
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors Fly app creation flows to use the Flaps API instead of the GraphQL-based CreateApp path, while preserving compatibility by refetching full app data where needed for rendering/output.
Changes:
- Switch app creation in machine run, launch, apps create, and postgres launcher paths from GraphQL to Flaps
CreateApp. - Wait for the newly created app via
WaitForAppusing the same Flaps client used to create it. - Reduce the returned app/app-compact data to only the fields needed by the calling code, refetching full app details for JSON output where required.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/command/machine/run.go | Uses Flaps to create ephemeral shell apps and machine-run apps; waits for app readiness and refetches compact app details when needed. |
| internal/command/launch/launch.go | Uses Flaps to create launch-plan apps and returns a minimal fly.App for follow-on printing/flow. |
| internal/command/apps/create.go | Uses Flaps to create apps; refetches full app via API client before JSON rendering to keep output compatible. |
| flypg/launcher.go | Uses Flaps to create postgres cluster apps and returns only required fly.AppCompact fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a8780ac to
7d61590
Compare
7d61590 to
d66179c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateAppto FlapsCreateAppfly apps create --jsoncompatible by refetching the full app before renderingTesting