Repository navigation
Conversation
Coverage Report for CI Build 41277796285Coverage decreased (-0.001%) to 86.947%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Local image transformations fail for accepted filenames such as
avatar@2x.png. Imgproxy treats the unescaped@as an output-format separator. Encode local sources at the same renderer boundary used for remote sources.Fixes #1641.
What changed
local://exception from source URL encoding.@, and multiple@characters through a real HTTP server and native fetch.Scope
This fixes local source URLs in image transformations. It does not address imgproxy's separate handling of
?in local filenames.Blast Radius
Local imgproxy requests now use the existing encoding applied to remote requests. Backend URL contracts and S3 source encoding remain unchanged.
Verification
FileBackendupload plusImageRendererand bundled imgproxy v3.26.0 produces a PNG of width 1 for versionedcat@2x.jpg. The same reproduction fails when the fix is removed and passes when restored.npm run build,npm run lint, andgit diff --checkpass. Full integration suite was not run.AI-assisted discovery, implementation, and review. Runtime results verified locally.