Repository navigation
fix(cli): suggest the replacement for removed config keys - #7593
Conversation
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 8 commands. Binary size: 135.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Claude's single finding is confirmed as a nonblocking consistency nit: several config-loading paths still discard the new suggestion. The updated start and stack handlers preserve it correctly. No additional findings; validation was static.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/command-internal/local-project-context.ts:39 |
consistency |
claude | Other config-loading paths still discard the removed-key suggestion. Commands using local-project-context, storage config loading, seed-buckets, signing-key config loading, or config-value-passthrough retain the generic '--debug' tip for an unsupported [inbucket] section. |
Findings outside the diff
- ⚪ NIT
apps/cli/src/command-internal/local-project-context.ts:39— Other config-loading paths still discard the removed-key suggestion. Commands using local-project-context, storage config loading, seed-buckets, signing-key config loading, or config-value-passthrough retain the generic '--debug' tip for an unsupported [inbucket] section.
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
9d746ea to
6b6370f
Compare
A config that still uses a removed key, such as [inbucket], failed with the generic "rerun with --debug" footer. CliConfigRemovedKeyError now carries a suggestion that replaces it in text and JSON output, passed through by start and the stack start, install, update and outdated commands. Removed keys are named by their dotted path instead of TOML table syntax, so the message reads the same for config.toml and config.jsonc.
6b6370f to
294275f
Compare
A config that still uses a removed key, such as an old
[inbucket]section, makessupabase startfail. The error says the key is unsupported, but it ends with the generic "Try rerunning the command with --debug" tip, which doesn't help fix the config.CliConfigRemovedKeyErrornow carries its own suggestion, which replaces that tip in text and JSON output. A config with one removed key prints:A config with several removed keys prints:
inbucket, not[inbucket]), so the message reads the same forconfig.tomlandconfig.jsonc. The file name already comes from the loaded path.startand the stack backend'sstart,install,updateandoutdatedpass the suggestion through from the config error.