Repository navigation
fix(cli): bump @supabase/typegen to 0.3.3 - #7585
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported no findings. Code inspection confirms the dependency versions, lockfile entries, and release-age exclusions are consistent. No fundamental conflict with the listed next-branch work is evident. Upstream package behavior could not be verified from the checked-out files.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 8 commands. Binary size: 135.0 MB, up 12.0 KB from 135.0 MB. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
jgoux
left a comment
There was a problem hiding this comment.
The bump makes supabase gen types fail outright against PostgreSQL 13 databases; details inline. The lockfile and minimumReleaseAgeExclude entries are otherwise consistent with the new versions.
The Supabase CLI is dropping PostgreSQL 13, which makes 14 the oldest version `introspect()` has to support. On 14, view column nullability and `RETURNS TABLE` column nullability inferred nothing: PostgreSQL 14 writes range table entries as `RTE` in its node trees, where 15 and later write `RANGETBLENTRY`, and the walk only accepted the latter. Every view column and every `RETURNS TABLE` column on a PostgreSQL 14 database was therefore generated as nullable. The walk now accepts both names, and on 14 the full test fixture produces exactly the same output as on 15. To keep the minimum supported version working, the parity test now runs on PostgreSQL 14 (`MINIMUM_POSTGRES_VERSION`) as well as 15, against the same golden files. A query that reads a catalog column added after 14, or any other difference in what 14 produces, fails every pull request. The view and `RETURNS TABLE` nullability suites include 14 too. Without the fix, 11 tests fail on 14; with it, the full suite passes. The README has a new "Supported PostgreSQL versions" section that names the minimum and where it is enforced. Generated output on PostgreSQL 15 and later is unchanged. Context: supabase/cli#7585 (comment) found that 0.8.0 fails on PostgreSQL 13, because it reads `pg_proc.prosqlbody`, which exists from 14. With 13 no longer supported, that query stays as it is.
Bumps
@supabase/typegento 0.3.3, which pulls in@supabase/postgrest-typegen0.8.0. That release infers column nullability for functions thatRETURNS TABLE, sosupabase gen typesemits more accurate return types for those functions.The
minimumReleaseAgeExcludeentries inpnpm-workspace.yamlmove to the new versions.Release notes: typegen 0.3.3, postgrest-typegen 0.8.0.