Skip to content

test(cli): stop gen types e2e matching DB ports that start with 1 - #7524

Merged
kanadgupta merged 1 commit into
developfrom
test/gen-types-e2e-port-collision
Nov 5, 2026
Merged

kanadgupta merged 1 commit into
developfrom
test/gen-types-e2e-port-collision

Conversation

@jgoux

@jgoux jgoux commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

The tokenless gen types e2e asserts the output never mentions the offline profile's http://127.0.0.1:1 API URL with a plain substring check. The CLI prints Target: local stack (127.0.0.1:<dbPort>), so whenever the randomly allocated DB port starts with 1 (e.g. 1191) the assertion fails even though no remote call happened. Seen on #7523.

The assertion now matches 127.0.0.1:1 only when no further port digit follows.

@jgoux
jgoux requested a review from a team as a code owner November 5, 2026 19:38
@jgoux
jgoux requested a review from kanadgupta November 5, 2026 19:38
@jgoux jgoux self-assigned this Nov 5, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed with no findings. Code inspection and five regex checks confirm the assertion still detects the offline profile’s port-1 URLs while allowing longer local database ports beginning with 1. No production behavior changes or conflicts with pending next-branch work were found.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit a96ab83 against develop at d3c5cb0 · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 220 ms 237 ms no real change (+8%, within normal variation)
supabase --help help 250 ms 259 ms no real change
supabase init init 253 ms 244 ms no real change
supabase migration new bench migration-new 261 ms 276 ms no real change (+6%, within normal variation)
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 249 ms 233 ms no real change (-6%, within normal variation)
supabase projects list projects-list 215 ms 211 ms no real change
supabase functions list --project-ref replayfixtureprojref functions-list 252 ms 245 ms no real change

API calls: unchanged for all 7 commands.

Binary size: 134.7 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 199-338 ms 189-403 ms +17 ms (+8%) within noise
supabase --help help 238-307 ms 226-295 ms +9 ms (+4%) within noise
supabase init init 209-325 ms 228-280 ms -9 ms (-3%) within noise
supabase migration new bench migration-new 235-400 ms 237-344 ms +15 ms (+6%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 210-281 ms 218-273 ms -15 ms (-6%) within noise
supabase projects list projects-list 194-231 ms 204-223 ms -4 ms (-2%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 217-403 ms 205-283 ms -7 ms (-3%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

@kanadgupta
kanadgupta added this pull request to the merge queue Nov 5, 2026
Merged via the queue into develop with commit 34f4125 Nov 5, 2026
55 checks passed
@kanadgupta
kanadgupta deleted the test/gen-types-e2e-port-collision branch November 5, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants