Repository navigation
test(cli): stop gen types e2e matching DB ports that start with 1 - #7524
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed with no findings. Code inspection and five regex checks confirm the assertion still detects the offline profile’s port-1 URLs while allowing longer local database ports beginning with 1. No production behavior changes or conflicts with pending next-branch work were found.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.7 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
The tokenless
gen typese2e asserts the output never mentions the offline profile'shttp://127.0.0.1:1API URL with a plain substring check. The CLI printsTarget: local stack (127.0.0.1:<dbPort>), so whenever the randomly allocated DB port starts with1(e.g.1191) the assertion fails even though no remote call happened. Seen on #7523.The assertion now matches
127.0.0.1:1only when no further port digit follows.