Skip to content

fix(stack): match legacy imgproxy tuning (CLI-2578) - #7483

Merged
7ttp merged 1 commit into
developfrom
7ttp/cli-2578-stack-small-service-env-parity-batch-and-pooler-tenant-auth
Nov 4, 2026
Merged

7ttp merged 1 commit into
developfrom
7ttp/cli-2578-stack-small-service-env-parity-batch-and-pooler-tenant-auth

Conversation

@7ttp

@7ttp 7ttp commented Nov 4, 2026

Copy link
Copy Markdown
Member

TL;DR

fixes image transforms on the stack returning different images than the legacy backend, by giving the stack's imgproxy the same settings

what's Improved?

on the stack, supabase start ran imgproxy without the tuning the legacy backend passes it
a png requested by a browser that accepts webp came back as png instead of webp

animated gifs came back as a single frame, and large photos skipped the default 3000px size cap

fixed now by:

the stack's imgproxy now gets the same tuning as the legacy backend, so transforms return the same images on both
IMGPROXY_USE_ETAG is left out because imgproxy treats its legacy value like unset, so nothing changes there

ref:

@7ttp 7ttp self-assigned this Nov 4, 2026
@7ttp
7ttp requested a review from a team as a code owner November 4, 2026 08:50
@7ttp
7ttp requested a review from Coly010 November 4, 2026 08:50
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit 766939f against develop at d2e9c6d · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 239 ms 250 ms no real change
supabase --help help 194 ms 194 ms no real change
supabase init init 166 ms 168 ms no real change
supabase migration new bench migration-new 251 ms 235 ms no real change (-6%, within normal variation)
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 305 ms 276 ms no real change (-10%, within normal variation)
supabase projects list projects-list 209 ms 208 ms no real change
supabase functions list --project-ref replayfixtureprojref functions-list 228 ms 237 ms no real change

API calls: unchanged for all 7 commands.

Binary size: 134.1 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 196-407 ms 191-376 ms +10 ms (+4%) within noise
supabase --help help 178-246 ms 163-276 ms 0 ms (0%) within noise
supabase init init 149-209 ms 151-195 ms +3 ms (+2%) within noise
supabase migration new bench migration-new 157-397 ms 157-444 ms -16 ms (-6%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 208-359 ms 222-312 ms -30 ms (-10%) within noise
supabase projects list projects-list 191-262 ms 189-263 ms -1 ms (-1%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 208-349 ms 220-256 ms +9 ms (+4%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed with no findings. Reading both changed files and the legacy imgproxy configuration confirmed that the six settings match legacy values and the integration assertion checks WebP negotiation. No additional actionable issues found. Tests were not run during adjudication.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@7ttp
7ttp added this pull request to the merge queue Nov 4, 2026
Merged via the queue into develop with commit a2dad15 Nov 4, 2026
55 checks passed
@7ttp
7ttp deleted the 7ttp/cli-2578-stack-small-service-env-parity-batch-and-pooler-tenant-auth branch November 4, 2026 09:54
TFSebben pushed a commit to TFSebben/supabase_cli that referenced this pull request Nov 4, 2026
## TL;DR

fixes Studio on the stack missing the local S3 keys, so creating a
vector bucket in Studio installs its wrapper like on the legacy backend

## ref:

- extends: supabase#7483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants