Skip to content

test(cli): mask default postgres image in container input goldens - #7442

Merged
avallete merged 2 commits into
developfrom
avallete/mask-postgres-image-in-precedence-goldens
Nov 2, 2026
Merged

avallete merged 2 commits into
developfrom
avallete/mask-postgres-image-in-precedence-goldens

Conversation

@avallete

@avallete avallete commented Nov 2, 2026

Copy link
Copy Markdown
Member

The local container inputs precedence goldens recorded the default Postgres image tag, so every Postgres bump PR (e.g. #7408) failed integration tests until the goldens were regenerated by hand.

The test now redacts the current default database image as <DEFAULT_POSTGRES_IMAGE>, keeping the goldens focused on config precedence.

🤖 Generated with Claude Code

Postgres bump PRs no longer need to regenerate these precedence goldens.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@avallete
avallete requested a review from a team as a code owner November 2, 2026 14:56
@avallete

avallete commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

/ai-review

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by a newer AI review

🤖 AI Review

Both independent reviews completed with no findings. Reading the changed test, catalog exports, serializer, and six snapshots confirmed that image normalization preserves the precedence assertions. No additional issues found. Tests were not run because dependencies are absent.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews were available. Confirmed Claude’s substring-redaction nit; current fixtures are unaffected, and non-default image suffixes remain distinguishable. No additional findings.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/command-internal/db-bootstrap/local-container-inputs.precedence.integration.test.ts:201 test-robustness claude The image redaction also matches prefixes of longer image tags. An OrioleDB image would serialize as <DEFAULT_POSTGRES_IMAGE>-orioledb, partially masking a non-default image.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

CLI benchmark (Lightweight Commands): no changes found

Commit 545f18f against develop at c4ffa9c · 10 runs each · report only, never blocks merging

Command Workload Before After Change
supabase --version version 268 ms 266 ms no real change
supabase --help help 322 ms 311 ms no real change
supabase init init 277 ms 303 ms no real change (+9%, within normal variation)
supabase migration new bench migration-new 305 ms 281 ms no real change (-8%, within normal variation)
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 293 ms 305 ms no real change
supabase projects list projects-list 462 ms 493 ms no real change (+7%, within normal variation)
supabase functions list --project-ref replayfixtureprojref functions-list 477 ms 492 ms no real change

API calls: unchanged for all 7 commands.

Binary size: 134.0 MB, unchanged.

Details: timing ranges, API calls per command, slowest phases

Timing ranges

Command Workload Before range After range Change Verdict
supabase --version version 218-400 ms 219-388 ms -3 ms (-1%) within noise
supabase --help help 252-513 ms 262-462 ms -12 ms (-4%) within noise
supabase init init 218-364 ms 224-329 ms +26 ms (+9%) within noise
supabase migration new bench migration-new 218-393 ms 256-405 ms -24 ms (-8%) within noise
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 220-367 ms 235-450 ms +12 ms (+4%) within noise
supabase projects list projects-list 252-578 ms 262-574 ms +32 ms (+7%) within noise
supabase functions list --project-ref replayfixtureprojref functions-list 446-566 ms 328-558 ms +15 ms (+3%) within noise

API calls per command

Command Workload Before After Endpoint changes
supabase --version version 0 0
supabase --help help 0 0
supabase init init 0 0
supabase migration new bench migration-new 0 0
supabase gen types --lang typescript --project-id replayfixtureprojref gen-types 2 2
supabase projects list projects-list 1 1
supabase functions list --project-ref replayfixtureprojref functions-list 2 2

Slowest phases

No command moved beyond noise, so there are no phase deltas.

Workflow run

Comment /bench to run the lightweight benchmark (this comment) again on the latest commit, or /bench full to also run the integration-heavy benchmark, which posts in its own comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@avallete
avallete added this pull request to the merge queue Nov 2, 2026
Merged via the queue into develop with commit ba3329c Nov 2, 2026
53 checks passed
@avallete
avallete deleted the avallete/mask-postgres-image-in-precedence-goldens branch November 2, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants