Repository navigation
test(cli): mask default postgres image in container input goldens - #7442
Conversation
Postgres bump PRs no longer need to regenerate these precedence goldens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/ai-review |
There was a problem hiding this comment.
Superseded by a newer AI review
🤖 AI Review
Both independent reviews completed with no findings. Reading the changed test, catalog exports, serializer, and six snapshots confirmed that image normalization preserves the precedence assertions. No additional issues found. Tests were not run because dependencies are absent.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Confirmed Claude’s substring-redaction nit; current fixtures are unaffected, and non-default image suffixes remain distinguishable. No additional findings.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/command-internal/db-bootstrap/local-container-inputs.precedence.integration.test.ts:201 |
test-robustness |
claude | The image redaction also matches prefixes of longer image tags. An OrioleDB image would serialize as <DEFAULT_POSTGRES_IMAGE>-orioledb, partially masking a non-default image. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The local container inputs precedence goldens recorded the default Postgres image tag, so every Postgres bump PR (e.g. #7408) failed integration tests until the goldens were regenerated by hand.
The test now redacts the current default database image as
<DEFAULT_POSTGRES_IMAGE>, keeping the goldens focused on config precedence.🤖 Generated with Claude Code