Repository navigation
chore(repo): sync develop into next #7128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6cc6ae2
ci: centralize Claude and Codex model ids (#7111)
avallete a36a396
ci(release): trigger sync repair when the AI review completes (#7114)
avallete 5f4ac9c
fix(cli): name the failing engine operation in stack telemetry (#7113)
avallete 21396b5
chore(cli): add permission building blocks for shared API calls (#7105)
Prashansa-K d5ac73f
ci(release): give sync repair the failing test output, not just the l…
avallete c7d2ba8
ci(release): land approved sync heads even when the source moved (#7125)
avallete e58c283
ci(stack): run macOS native scenarios on a larger runner (#7126)
avallete 4038b13
feat(cli): warn at runtime on deprecated db pull and domains flags (C…
Coly010 6baa653
chore(cli): map secrets list, snippets list and db query permissions …
Prashansa-K d09c050
Merge remote-tracking branch 'origin/next' into sync/develop-into-next
github-actions[bot] 7954e73
chore(repo): fix the develop-into-next merge
github-actions[bot] 66f816a
chore(repo): repair the develop-into-next sync
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "$comment": "Model IDs by family and tier. A new model can also need the Claude Code or Codex CLI version pinned in the workflows that read this file bumped.", | ||
| "claude": { | ||
| "opus": "claude-opus-5-5", | ||
| "sonnet": "claude-sonnet-5-5", | ||
| "haiku": "claude-haiku-5-5" | ||
| }, | ||
| "codex": { | ||
| "sol": "gpt-6.1-sol" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Severity: LOW
A failing check can print attacker-controlled text after
FAILor##[error]; this copies 40 following log lines into the repair agent's context. An injected directive can make the model mark an unresolved AI finding fixed, and Publish uses that result to resolve the GitHub thread, suppressing a security-review signal.Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: Treat the CI failure excerpt as untrusted data, not as instructions. Where ci-failures.md is built or interpolated into the repair agent's prompt, wrap the excerpt in a clearly delimited block, such as a fenced block with a random nonce. Tell the model to ignore any directives inside it. Strip or neutralize control sequences and any text that imitates prompt structure. Do not let model output alone decide whether a finding is resolved. Before Publish resolves a GitHub review thread, check independently that the originating check now passes or that the code changed as expected. Keep the log excerpt limited to what the model needs to diagnose the failure. Most of these changes belong where the prompt is assembled and where Publish resolves threads, not at line 623.