Repository navigation
ci(repo): re-read the slim mirror destination tag before failing - #6774
Merged
avallete merged 2 commits intoSep 24, 2026
Merged
Conversation
ECR Public can keep serving a tag's previous digest (or a 404 for a new tag) for a short while after a push, so the destination digest check now re-reads the tag up to 13 times, 10 s apart. The source check stays single-shot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
All three findings are confirmed. The destination check retries permanent command failures for up to two minutes. Direct callers of the exported verifier can cause an unbounded loop with NaN attempts, although main validates the workflow value. The sleep fallback is duplicated.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | .github/scripts/mirror-slim-image.ts:115 |
robustness |
claude | Calling verifyDigest directly with NaN attempts causes an unbounded retry loop. |
| 🟡 MINOR | .github/scripts/mirror-slim-image.ts:128 |
error-handling |
codex | The destination check retries permanent regctl failures, including authentication errors, before reporting them. |
| ⚪ NIT | .github/scripts/mirror-slim-image.ts:503 |
style |
claude | main supplies a Bun.sleep fallback that verifyDigest already supplies. |
Stats
Claude findings: 2 · Codex findings: 1 · Confirmed: 3 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Re-read the destination tag only on a digest mismatch or a 404, so authentication and other registry errors fail on the first read. verifyDigest now rejects a non-integer or non-positive attempt count itself, and main no longer duplicates its sleep fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
avallete
enabled auto-merge
September 24, 2026 10:29
Coly010
approved these changes
Sep 24, 2026
avallete
deleted the
avallete/four-destination-mirror-failures-32fc5d
branch
September 24, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror Slim Imagesometimes fails its destination check withpublic.ecr.aws/supabase/cli/<service>:<version> resolves to <X>, expected <Y>(orresolves to missingfor a new tag), even though the copy succeeded.In these failures
<X>is the tag's previous build digest. No other writer touches the tag afterward, the sender's own poll sees the expected digest seconds later, and the tag converges without a re-run. ECR Public serves a stale tag for a short time after an overwrite; this isn't a race between writers. Mirror runs for the same(service, version)are already serialized by the workflow's concurrency group.verify-digestnow accepts an optionalATTEMPTS(default 1) and re-reads the tag 10 s apart until it matches. Only the destination check setsATTEMPTS: "13"(~2 min, well within the job timeout). The source check stays single-shot because it's the check that the dispatch payload can be trusted.Linked issue
Supabase maintainer change; no linked issue.
🤖 Generated with Claude Code