Repository navigation
chore(stack): pin imgproxy to v3.8.0 #6752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,7 +99,7 @@ const definitions: Readonly<Record<ServiceKind, ArtifactDefinition>> = { | |
| imgproxy: definition( | ||
| "imgproxy", | ||
| "v3.8.0", | ||
| "ghcr.io/supabase/cli/imgproxy:v3.8.0", | ||
| "ghcr.io/supabase/cli/imgproxy:v3.8.0@sha256:75fcf5f5a72bc4bce354d1b5dfb4636a2e6979f0ce68cdacc51ed1bce2ab494e", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Severity: MEDIUM While the digest pin improves reproducibility, it locks the stack to imgproxy v3.8.0, affected by CVE-2023-1496. A malicious uploaded SVG can flow through Storage’s image-transformation request into imgproxy’s SVG renderer, whose generated response is returned to the requester, enabling script execution through the transformed image. 💡 Fix SuggestionSuggestion: Upgrade the imgproxy pin from v3.8.0 to v3.14.0 or later to remediate CVE-2023-1496. This requires two coordinated updates in the same definition block:
The correct digest must be retrieved from the GHCR registry for the Supabase CLI wrapper image ( or by inspecting the package page at https://github.com/supabase/cli/pkgs/container/cli%2Fimgproxy. Do not remove the digest pin when upgrading, as it is important for supply-chain integrity. |
||
| "bin/imgproxy", | ||
| ), | ||
| functions: definition( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Severity: MEDIUM
While the digest pin improves reproducibility, it locks the stack to imgproxy v3.8.0, affected by CVE-2023-30019. A caller-controlled image source from Storage reaches imgproxy’s fetcher; its vulnerable URL handling can request loopback/internal services and return their contents, enabling SSRF.
Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: Upgrade imgproxy from v3.8.0 to v3.15.0 or later to remediate CVE-2023-30019. The fix requires two coordinated changes in the
imgproxy: definition(...)block:"v3.8.0"to the patched version (e.g."v3.15.0").ghcr.io/supabase/cli/imgproxy(the Supabase-mirrored image). The new digest must be fetched from the registry (e.g.docker manifest inspect ghcr.io/supabase/cli/imgproxy:v3.15.0 --verbose | jq '.[0].Descriptor.digest') to maintain digest pinning. The dispatch workflow that created this PR (mirror-slim-image) should be re-run targeting v3.15.0 or newer to automatically populate the correct version string and digest.